Shoryuken Posted September 22, 2015 Report Share Posted September 22, 2015 Hi, I have read some similar problems on the forum but I can't find a solution. Sorry if have not looked well enough When I select the channel 2, 3, 4, 5 or 6 (with the joystick menu) and I play some notes with my MIDI keyboard, the sounds don't stop (until I play an other note)The channel 1 is the only one on which the sounds ends when I release the key. I think it's not related to my MIDI keyboard : I can see all the NoteOff MIDI messages in the console. I have tried a few things, for example- set channel 3 or 4 as default channel- set the same SID instruments on channel 1 and 2.- play with the Retrocade Synth Dashboard via USBBut it always produces the same problem. The problem happens both when I load the Audio_Retrocade_Synth example with DesignLab and when I load the .BIT file (RetroCade-1.3-zpuino-2.0-PapilioPro-S6LX9-RetroCade-1.3- with the PapilioLoader. Unfortunately, my MIDI controller send notes only through Channel 1. I don't have the possibility to send notes directly over the other MIDI channels. Any idea ?Thanks Quote Link to comment Share on other sites More sharing options...
Jack Gassett Posted September 22, 2015 Report Share Posted September 22, 2015 Hmmmm, interesting! You see the note off messages then. Can you check to see if the Noteoff is reporting the correct channel information? I suspect that somehow the note off is being sent to channel 1 all of the time instead of the correct channel... Jack. Quote Link to comment Share on other sites More sharing options...
offroad Posted September 22, 2015 Report Share Posted September 22, 2015 Hi, some MIDI keyboards send noteoff as a separate message, whereas others send a second noteon with velocity 0.It could be related to that (a bug, though). Quote Link to comment Share on other sites More sharing options...
Jack Gassett Posted September 22, 2015 Report Share Posted September 22, 2015 Yes, that was what I thought the problem was at first. But he says he is using the DesignLab version. In that version I updated the MIDI library so that it should be handling both cases of Note off and velocity 0... Quote Link to comment Share on other sites More sharing options...
Shoryuken Posted September 23, 2015 Author Report Share Posted September 23, 2015 Thank you Jack ! You have guided me to the solution ! I've finally found In Audio_RetroCade_Synth.ino, in the HandleNoteOn function, I've replacedlastpitch[channel-1]=pitch;byte activeChannel = retrocade.getActiveChannel();if ( activeChannel != 0 ) channel = activeChannel;by :byte activeChannel = retrocade.getActiveChannel();if ( activeChannel != 0 ) channel = activeChannel;lastpitch[channel-1]=pitch;This line always prevented the HandleNoteOff function to work when channel != 1 : if (lastpitch[channel-1]!=pitch) { return; } Quote Link to comment Share on other sites More sharing options...
Jack Gassett Posted September 23, 2015 Report Share Posted September 23, 2015 Yahoo! I'm glad you found a solution. I just commited your changes to the source code so it will be there in the next release of DesignLab:https://github.com/GadgetFactory/DesignLab_Examples/commit/d20cfc3cb56ba49a121995dd94a64f1711287ea2 Thanks!Jack. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.